Skip to content

fixing logging

Sesboue Matthias requested to merge fix/logging into olms2

As I tried to build my project using olaf, I got an error when importing the entire package (import olaf), not when installing it, due to logging. So, I read a bit and discovered we should not define our logging file but rather provide our logger.

We also forgot an __init__.py file to make the repository folder a package (it was causing another error when importing olaf).

I made the changes and added the dependencies to the setup.py so that they are automatically downloaded when installing the package.

To test on your side:

  • in a separate folder, as if you were starting a new project, create a new environment and pip install olaf (from the fix/logging branch): pip install git+https://gitlab.insa-rouen.fr/msesboue/ontology-learning.git@fix/logging
  • In a notebook (or any Python executable file), run import olaf and from olaf import *.

Overall, this MR should solve the following issues: #60 (closed) #59 (closed)

Merge request reports